Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workspace scale animations #7501

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement workspace scale animations #7501

wants to merge 6 commits into from

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Aug 24, 2024

Breaks some animation configs, fade/anim got split:

  • fadeWorkspaces, fadeWorkspacesIn, fadeSpecialWorkspace etc

new style: popin optionally % popin 20%

slidefade removed (fade + slide is possible separately)

needs a few tests to make sure I didnt break something badly

@gulafaran
Copy link
Contributor

closing nested hits this.

/home/tom/dev/Hyprland/src/render/Renderer.cpp:519:31: runtime error: member access within null pointer of type 'struct CWorkspace'
    #0 0x555569915982 in CHyprRenderer::renderWorkspaceWindows(CMonitor*, Hyprutils::Memory::CSharedPointer<CWorkspace>, timespec*) /home/tom/dev/Hyprland/src/render/Renderer.cpp:519
    #1 0x55556992919c in CHyprRenderer::renderAllClientsForWorkspace(CMonitor*, Hyprutils::Memory::CSharedPointer<CWorkspace>, timespec*, Hyprutils::Math::Vector2D const&, float const&) /home/tom/dev/Hyprland/src/render/Renderer.cpp:960
    #2 0x55556993d00f in CHyprRenderer::renderWorkspace(CMonitor*, Hyprutils::Memory::CSharedPointer<CWorkspace>, timespec*, Hyprutils::Math::CBox const&) /home/tom/dev/Hyprland/src/render/Renderer.cpp:1543
    #3 0x5555699376ff in CHyprRenderer::renderMonitor(CMonitor*) /home/tom/dev/Hyprland/src/render/Renderer.cpp:1376
    #4 0x55556842124e in Events::listener_monitorFrame(void*, void*) /home/tom/dev/Hyprland/src/events/Monitors.cpp:84
    #5 0x5555684b3f38 in operator() /home/tom/dev/Hyprland/src/helpers/Monitor.cpp:43
    #6 0x5555684e1ff6 in __invoke_impl<void, CMonitor::onConnect(bool)::<lambda(std::any)>&, std::any> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/invoke.h:61
    #7 0x5555684ddb00 in __invoke_r<void, CMonitor::onConnect(bool)::<lambda(std::any)>&, std::any> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/invoke.h:111
    #8 0x5555684da74a in _M_invoke /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/std_function.h:290
    #9 0x7ffff703600b in Hyprutils::Signal::CSignalListener::emit(std::any) (/usr/lib64/libhyprutils.so.1+0x800b)
    #10 0x7ffff703657d in Hyprutils::Signal::CSignal::emit(std::any) (/usr/lib64/libhyprutils.so.1+0x857d)
    #11 0x7ffff773de55 in Aquamarine::CWaylandOutput::sendFrameAndSetCallback() (/usr/lib64/libaquamarine.so.2+0x7be55)
    #12 0x7ffff773e175 in Aquamarine::CWaylandOutput::onFrameDone() (/usr/lib64/libaquamarine.so.2+0x7c175)
    #13 0x7ffff7772485  (/usr/lib64/libaquamarine.so.2+0xb0485)
    #14 0x7ffff6750549  (/usr/lib64/libffi.so.8+0x8549)
    #15 0x7ffff674c27d  (/usr/lib64/libffi.so.8+0x427d)
    #16 0x7ffff674f9ca in ffi_call (/usr/lib64/libffi.so.8+0x79ca)
    #17 0x7ffff7654c14  (/usr/lib64/libwayland-client.so.0+0x4c14)
    #18 0x7ffff7654f3a  (/usr/lib64/libwayland-client.so.0+0x4f3a)
    #19 0x7ffff7659fd7 in wl_display_dispatch_pending (/usr/lib64/libwayland-client.so.0+0x9fd7)
    #20 0x7ffff773869c in Aquamarine::CWaylandBackend::dispatchEvents() (/usr/lib64/libaquamarine.so.2+0x7669c)
    #21 0x555568508640 in std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/std_function.h:591
    #22 0x5555689189b6 in aquamarineFDWrite /home/tom/dev/Hyprland/src/managers/eventLoop/EventLoopManager.cpp:41
    #23 0x7ffff766a6b2  (/usr/lib64/libwayland-server.so.0+0xa6b2)
    #24 0x7ffff766b508 in wl_display_run (/usr/lib64/libwayland-server.so.0+0xb508)
    #25 0x5555689192c1 in CEventLoopManager::enterLoop() /home/tom/dev/Hyprland/src/managers/eventLoop/EventLoopManager.cpp:53
    #26 0x555567b8e981 in CCompositor::startCompositor() /home/tom/dev/Hyprland/src/Compositor.cpp:697
    #27 0x55556861b714 in main /home/tom/dev/Hyprland/src/main.cpp:157
    #28 0x7ffff5c2a096  (/usr/lib64/libc.so.6+0x2a096)
    #29 0x7ffff5c2a156 in __libc_start_main (/usr/lib64/libc.so.6+0x2a156)
    #30 0x555567b7c3f0 in _start (/home/tom/dev/Hyprland/build/Desktop-Debug/Hyprland+0x126283f0)
    ```

@vaxerski
Copy link
Member Author

ye I hit it too, fixd

@vaxerski
Copy link
Member Author

works on my end

@vaxerski
Copy link
Member Author

ugh, starting to realize the issues with this. idk if this is a good idea after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants