Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider keeping sidebar state when opening modals via native dialog. #6190

Open
acelaya opened this issue Feb 12, 2024 · 0 comments
Open

Consider keeping sidebar state when opening modals via native dialog. #6190

acelaya opened this issue Feb 12, 2024 · 0 comments

Comments

@acelaya
Copy link
Contributor

acelaya commented Feb 12, 2024

For historical reasons, we have been hiding the sidebar when modals like the notebook were opened. However, we have recently refactored it to use a native dialog element, opened via dialog.showModal().

This provides proper focus trapping on the dialog itself, natively handled by the browser, which means we could keep the sidebar as is, reducing the complexity and cross-frame communication logic involved in opening/closing the notebook.

However, it would be good to check if there were some reason for this to be implemented using this approach, other than the lack of focus trapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants