Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-pressed not used for "Show highlights" button #6166

Closed
Tracked by #6151
acelaya opened this issue Feb 1, 2024 · 0 comments · Fixed by #6167
Closed
Tracked by #6151

aria-pressed not used for "Show highlights" button #6166

acelaya opened this issue Feb 1, 2024 · 0 comments · Fixed by #6167
Assignees
@acelaya
Labels
accessibility

Comments

@acelaya
Copy link
Contributor

acelaya commented Feb 1, 2024 •
edited
Loading

Part of #6151

The Show highlights button does not have an aria-pressed attribute, but it acts as a toggle button so it would benefit from this attribute to help communicate its state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acelaya acelaya

Labels
accessibility
Projects
No open projects
Accessibility improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aria-pressed attribute to highlights toggle hypothesis/client
1 participant
@acelaya