[Bug] yarn run build and yarn run start not working on Windows Machine

[wxharry]

Description

In the commit fix: exsiting way to write process.env.XXX does not work, we changed the way to specify environment variables. However, the wary of adding the env variables directly to yarn run build and yarn run start doesn't work for windows Machine. Catch error:

becuase we are using windows cmd and the commands are different.

How do we solve this?

[tyn1998]

Hi, @wxharry, it was a mistake. Thank you for reporting it!

Before #274:

hypertrons-crx/package.json

Lines 7 to 14 in b6dc905

	"scripts": {
	"start": "node utils/webserver.js",
	"watch": "cross-env NODE_ENV=development node utils/build.js",
	"watch:mock": "cross-env NODE_ENV=development MOCK=true node utils/build.js",
	"web-ext": "web-ext run --target=chromium",
	"build": "cross-env NODE_ENV=production node utils/build.js",
	"prettier": "prettier --write '**/*.{js,jsx,css,html}'"
	},

After #274, all things that related to cross-env are removed because they are not needed anymore until #384 comes out. But apparently I ignored the different shell syntax between windows cmd/powershell and unix-like bash/zsh/fish/git-bash then.

We should use cross-env again.

[tyn1998]

What shell did you use?

[wxharry]

windows cmd

[tyn1998]

Now I know more about git bash, "bash" is more important.

[wxharry]

/self-assign