Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node_control_utils.hold_packages more robust. #1742

Open
WadeBarnes opened this issue Mar 29, 2022 · 1 comment
Open

Make node_control_utils.hold_packages more robust. #1742

WadeBarnes opened this issue Mar 29, 2022 · 1 comment
Labels
enhancement good first issue help wanted Ubuntu 20.04 Ubuntu 20.04 related activity.

Comments

@WadeBarnes
Copy link
Member

The /indy_node/utils/node_control_utils.py, hold_packages method will cause the indy-node-control service to crash when it attempts to hold a package that is not installed on the system. This also causes the indy-node service to restart.

Add some error handling to the code so the method will simply log the fact that it tried to hold a package that does not exist rather than erroring out and causing the indy-node-control service to crash.

References:
@ggold7046
Copy link

Hi @WadeBarnes, I'm new to Hyperledger and oss. Could you please tell me the problem in details and guide me how to solve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted Ubuntu 20.04 Ubuntu 20.04 related activity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WadeBarnes @ggold7046