Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syncing docs #1717

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Oct 18, 2024

Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran alexandratran requested a review from a team as a code owner October 18, 2024 00:08
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:53pm

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment

Co-authored-by: Joan E <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit cfad970 into hyperledger:main Oct 21, 2024
10 checks passed
@alexandratran alexandratran deleted the 1715-update-syncing branch October 21, 2024 17:30
bgravenorst pushed a commit to bgravenorst/besu-docs that referenced this pull request Oct 22, 2024
* Update syncing docs

Signed-off-by: Alexandra Tran <[email protected]>

* Update options.md

Co-authored-by: Joan E <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>

* address reviewer feedback + edits

Signed-off-by: Alexandra Tran <[email protected]>

---------

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>
Co-authored-by: Joan E <[email protected]>
bgravenorst added a commit that referenced this pull request Oct 22, 2024
* Add tx pool CLI option.

Signed-off-by: bgravenorst <[email protected]>

* Add extra clarification.

Signed-off-by: bgravenorst <[email protected]>

* Address reviewer feedback.

Signed-off-by: bgravenorst <[email protected]>

* Typo.

Signed-off-by: bgravenorst <[email protected]>

* Fix additional typos.

Signed-off-by: bgravenorst <[email protected]>

* Minor edits.

Signed-off-by: bgravenorst <[email protected]>

* Update syncing docs (#1717)

* Update syncing docs

Signed-off-by: Alexandra Tran <[email protected]>

* Update options.md

Co-authored-by: Joan E <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>

* address reviewer feedback + edits

Signed-off-by: Alexandra Tran <[email protected]>

---------

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>
Co-authored-by: Joan E <[email protected]>

* Update to match other Besu headings

Signed-off-by: bgravenorst <[email protected]>

---------

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Carrillo <[email protected]>
Co-authored-by: Joan E <[email protected]>
Co-authored-by: Alexandra Carrillo <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sync page
2 participants