Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate Mike Sanko as docs maintainer #1433

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Nov 6, 2023

Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran alexandratran requested a review from a team as a code owner November 6, 2023 22:17
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 10:25pm

@alexandratran alexandratran changed the title Add Mike Sanko as docs maintainer Nominate Mike Sanko as docs maintainer Nov 6, 2023
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjsmike62
Copy link
Contributor

mjsmike62 commented Nov 7, 2023 via email

@mjsmike62
Copy link
Contributor

I graciously accept the nomination to become a Besu documentation maintainer and I'm willing to be a long-term maintainer.

@alexandratran alexandratran requested review from a team November 7, 2023 22:23
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran
Copy link
Contributor Author

14 approvals (including myself) should suffice as an absolute majority of Besu docs maintainers and Besu maintainers to approve this nomination.

@alexandratran alexandratran merged commit 0a4cd4e into hyperledger:main Nov 15, 2023
9 checks passed
ATREAY pushed a commit to ATREAY/besu-docs that referenced this pull request Nov 15, 2023
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Atreay Kukanur <[email protected]>
ATREAY pushed a commit to ATREAY/besu-docs that referenced this pull request Nov 16, 2023
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Atreay Kukanur <[email protected]>
@alexandratran alexandratran deleted the mike-maintainer branch January 31, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.