Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update evm tool docs #1428

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

Signed-off-by: Alexandra Tran <[email protected]>
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 2:33am

Copy link
Contributor

@non-fungible-nelson non-fungible-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall text LGTM - I'll give my approval but will wait for Danno to provide a review of the tool usage / examples etc.

Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General style, I prefer calling it 'EVM bytecote' when talking about data that is being executed instead of 'EVM' (such as 'executes arbitrary EVM')

I'm OK leaving out the two subcommands not already described. For posterity the benchmark sub command benchmarks the performance of precompiled contracts and crypto primitives. the b11r/blockbuilder sub command is used by execution-spec-tests and the tests specify no public API I am aware of, other than what can be gleaned by reading their code. But I do not expect non-maintainers will ever interface with those commands.

docs/public-networks/how-to/troubleshoot/evm-tool.md Outdated Show resolved Hide resolved
docs/public-networks/reference/evm-tool.md Outdated Show resolved Hide resolved
docs/public-networks/reference/evm-tool.md Outdated Show resolved Hide resolved
docs/public-networks/reference/evm-tool.md Outdated Show resolved Hide resolved
Alexandra Tran and others added 2 commits October 26, 2023 15:03
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran Carrillo <[email protected]>
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

docs/public-networks/how-to/troubleshoot/evm-tool.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/troubleshoot/evm-tool.md Outdated Show resolved Hide resolved
Alexandra Tran and others added 2 commits October 26, 2023 19:20
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran Carrillo <[email protected]>
@alexandratran alexandratran merged commit 9fa03b3 into hyperledger:main Oct 27, 2023
8 checks passed
@alexandratran alexandratran deleted the 1375-evm-tool branch October 27, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EVM tool docs
4 participants