-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update evm tool docs #1428
update evm tool docs #1428
Conversation
Signed-off-by: Alexandra Tran <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall text LGTM - I'll give my approval but will wait for Danno to provide a review of the tool usage / examples etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General style, I prefer calling it 'EVM bytecote' when talking about data that is being executed instead of 'EVM' (such as 'executes arbitrary EVM')
I'm OK leaving out the two subcommands not already described. For posterity the benchmark
sub command benchmarks the performance of precompiled contracts and crypto primitives. the b11r
/blockbuilder
sub command is used by execution-spec-tests and the tests specify no public API I am aware of, other than what can be gleaned by reading their code. But I do not expect non-maintainers will ever interface with those commands.
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran Carrillo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran Carrillo <[email protected]>
Update EVM tool docs.
Fixes #1375
Supersedes #1427
preview: