Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API is enabled by default #1411

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

chong-he
Copy link
Contributor

@chong-he chong-he commented Oct 2, 2023

The Engine API is enabled by default (without needing the flag --engine-rpc-enabled). This PR removes the line that states it is disabled by default and some that are not required.

Signed-off-by: Tan Chee Keong <[email protected]>
@chong-he chong-he requested a review from a team as a code owner October 2, 2023 10:05
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:39pm

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Tan Chee Keong <[email protected]>
@chong-he
Copy link
Contributor Author

chong-he commented Oct 5, 2023

Can you also update the option default to true? https://besu.hyperledger.org/development/public-networks/reference/cli/options#engine-rpc-enabled

Revised in 3b3dfd7

Also modify here: https://besu.hyperledger.org/public-networks/reference/engine-api since the Engine API is enabled by default

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording edits.

docs/public-networks/how-to/use-engine-api.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/use-engine-api.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandra Tran Carrillo <[email protected]>
@alexandratran alexandratran merged commit 68fea25 into hyperledger:main Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants