-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated public API methods containing blockNumber #1402
Updated public API methods containing blockNumber #1402
Conversation
Signed-off-by: Mike Sanko <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a few updates:
admin_logsRemoveCache
fromBlock
andtoBlock
missing "hexadecimal"eth_feeHistory
newestBlock
missing "hexadecimal"debug_getRawReceipts
blockNumber
missing both "hexadecimal" and the new string tags
@alexandratran, the only place where I can find that |
Signed-off-by: Mike Sanko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockNumber can be hex OR decimal - see
https://besu.hyperledger.org/development/public-networks/how-to/use-besu-api/json-rpc#block-parameter
so you could have "0x10" or "16" and either would work
Signed-off-by: Mike Sanko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion on wording
…ockNumber` Signed-off-by: Mike Sanko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions for missed edits. You can go to Files changed on this PR, and for each suggestion, Add suggestion to batch. Then simply commit all my suggestions at once.
Signed-off-by: Mike Sanko <[email protected]>
Co-authored-by: Alexandra Tran Carrillo <[email protected]> Signed-off-by: Mike Sanko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated public API methods containing the
blockNumber
parameter, specifying that they arehexadecimal integer
and also addedfinalized
andsafe
to the string tags listing. Also, addedfinalized
andsafe
to other public API methods that were missing these tags.Fixes #1385
See https://besu-docs-1sz5lp094-hyperledger.vercel.app/development/public-networks/reference/api
See:
https://besu-docs-lnswwc430-hyperledger.vercel.app/development/public-networks/reference/api
https://besu-docs-lnswwc430-hyperledger.vercel.app/development/private-networks/reference/api