Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Orderer check via logs is not robust #29

Open
nicolapaoli opened this issue Mar 22, 2019 · 2 comments
Open

Orderer check via logs is not robust #29

nicolapaoli opened this issue Mar 22, 2019 · 2 comments
Assignees
Labels
bug Something isn't working fabric Hyperledger Fabric issue good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicolapaoli
Copy link
Contributor

After deploying a network and leaving it for some time without activity, the orderer log that check it is functioning stalls.

@nicolapaoli nicolapaoli added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers fabric Hyperledger Fabric issue labels Mar 22, 2019
@nicolapaoli nicolapaoli added this to the Performance Enhancement milestone Mar 22, 2019
@inzamam-iqbal
Copy link
Contributor

Hyperledger 1.4 peer and orderer supports helath checks where we can just get the health status by sending a GET request to /healthz. So utilizing that feature after updating to hyperladger 1.4 will be the best solution for this.

@alexvicegrab
Copy link
Contributor

Agreed, I would suggest to add these health checks, and if we don't find the /healthz, to default to the old code, but add a deprecation notice. This would mention that in 3/6/12 months (I favour 6, but we can perhaps vote on this?), we will stop supporting Fabric >1.4, so that this change does not come as a surprise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fabric Hyperledger Fabric issue good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants