Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom pod properties to crd #96

Open
tbondarchuk opened this issue Feb 13, 2023 · 1 comment
Open

Add support for custom pod properties to crd #96

tbondarchuk opened this issue Feb 13, 2023 · 1 comment

Comments

@tbondarchuk
Copy link

Currently there are no way to pass custom pod configs via crds, like nodeSelector/tolerations/topologySpreadConstraints/affinity/etc (unless I'm missing something?)

There is only arch/zone/region though not sure what exactly they configure, labels?

@tbondarchuk
Copy link
Author

Was able to trace to here:

nodeSelectorTerms := common.GetNodeSelectorTerms(arch, zone, region)

nothing for toleration or custom labels for nodeSelector.

Also - sample-network creates pods with quite inconsistent affinity:

ca

          podAntiAffinity:
            preferredDuringSchedulingIgnoredDuringExecution:
            - podAffinityTerm:
                labelSelector:
                  matchExpressions:
                  - key: app
                    operator: In
                    values:
                    - org0-ca
                topologyKey: topology.kubernetes.io/zone
              weight: 100
            - podAffinityTerm:
                labelSelector:
                  matchExpressions:
                  - key: app
                    operator: In
                    values:
                    - org0-ca
                topologyKey: failure-domain.beta.kubernetes.io/zone
              weight: 100

orderer

        affinity:
          podAntiAffinity:
            preferredDuringSchedulingIgnoredDuringExecution:
            - podAffinityTerm:
                labelSelector:
                  matchExpressions:
                  - key: orgname
                    operator: In
                    values:
                    - OrdererOrg
                topologyKey: kubernetes.io/hostname
              weight: 100

peer

        affinity:
          podAntiAffinity:
            preferredDuringSchedulingIgnoredDuringExecution:
            - podAffinityTerm:
                labelSelector:
                  matchExpressions:
                  - key: orgname
                    operator: In
                    values:
                    - Org1MSP
                topologyKey: kubernetes.io/hostname
              weight: 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant