Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infallible revoke of associated permissions on unregistering entities #5244

Open
s8sato opened this issue Nov 19, 2024 · 0 comments
Open

Infallible revoke of associated permissions on unregistering entities #5244

s8sato opened this issue Nov 19, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@s8sato
Copy link
Contributor

s8sato commented Nov 19, 2024

I don't think those revokes are currently expected to be infallible. For example, who CanUnregisterDomain can fail to revoke CanModifyDomainMetadata in visit_unregister_domain.
Or we could consider this as a bug that should be eliminated in another issue, and make it panic or ValidationFail::InternalError

Originally posted by @s8sato in #5239 (comment)
@s8sato s8sato added the Bug Something isn't working label Nov 19, 2024
@s8sato s8sato changed the title Make it infallible for associated permissions to cascade on unregister entities Infallible revoke of associated permissions on unregistering entities Nov 19, 2024
@s8sato s8sato mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s8sato