Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Update EDV provider dependency, update golintci, update go docker #3418

Merged

Conversation

DRK3
Copy link
Contributor

@DRK3 DRK3 commented Oct 25, 2022

Resolves some go module issues that appeared from the previous commit.

Changes include:

  • Updated the component/storage/edv dependency
  • Updated golintci version
  • Updated Golang docker version for building images
  • Fix for BBS interop tests

Note that many linters were disabled for this commit. Some (most?) of them should be re-enabled (and code updated) in a future commit.

Signed-off-by: Derek Trider [email protected]

@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch 2 times, most recently from 69bcab5 to 9510b15 Compare October 26, 2022 18:12
@DRK3 DRK3 changed the title chore: Update EDV provider dependency feat: Update EDV provider dependency, fix Go module error Oct 26, 2022
@DRK3 DRK3 changed the title feat: Update EDV provider dependency, fix Go module error WIP: feat: Update EDV provider dependency, fix Go module error Oct 26, 2022
@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch 4 times, most recently from 366f1cc to 6164e9f Compare October 26, 2022 19:05
@DRK3 DRK3 changed the title WIP: feat: Update EDV provider dependency, fix Go module error feat: Update EDV provider dependency, update golintci, update go docker Oct 26, 2022
@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch 2 times, most recently from 81eda86 to 554ce69 Compare October 26, 2022 19:10
@DRK3
Copy link
Contributor Author

DRK3 commented Oct 26, 2022

Created some important followup issues: #3419, #3420, #3421

@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch 14 times, most recently from c059ee1 to d779dcd Compare October 27, 2022 19:44
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #3418 (d779dcd) into main (368f53b) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

❗ Current head d779dcd differs from pull request most recent head d1c0a4c. Consider uploading reports for the commit d1c0a4c to get more accurate results

@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.01%     
==========================================
  Files         343      343              
  Lines       46809    46832      +23     
==========================================
+ Hits        40994    41010      +16     
- Misses       4318     4323       +5     
- Partials     1497     1499       +2     
Impacted Files Coverage Δ
...to/primitive/aead/aes_cbc_hmac_aead_key_manager.go 90.74% <ø> (ø)
...tinkcrypto/primitive/bbs/bbs_signer_key_manager.go 83.46% <ø> (ø)
...nkcrypto/primitive/bbs/bbs_verifier_key_manager.go 100.00% <ø> (ø)
...composite/ecdh/ecdh_nistpkw_private_key_manager.go 90.07% <ø> (ø)
.../composite/ecdh/ecdh_nistpkw_public_key_manager.go 88.88% <ø> (ø)
...omposite/ecdh/ecdh_x25519kw_private_key_manager.go 82.94% <ø> (ø)
...composite/ecdh/ecdh_x25519kw_public_key_manager.go 88.88% <ø> (ø)
...imitive/composite/register_ecdh_aead_enc_helper.go 87.94% <ø> (ø)
...rimitive/secp256k1/secp256k1_signer_key_manager.go 82.90% <ø> (-2.57%) ⬇️
...mitive/secp256k1/secp256k1_verifier_key_manager.go 65.71% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch 2 times, most recently from ccf571c to 6f4e4a1 Compare October 27, 2022 20:53
Resolves some go module issues that appeared from the previous commit.

Changes include:

* Updated the component/storage/edv dependency
* Updated golintci version
* Updated Golang docker version for building images
* Fix for BBS interop tests

Note that many linters were disabled for this commit. Some (most?) of them should be re-enabled (and code updated) in a future commit.

Signed-off-by: Derek Trider <[email protected]>
@DRK3 DRK3 force-pushed the UpdateEDVProviderDependency branch from 6c1203b to d1c0a4c Compare October 27, 2022 21:53
@fqutishat fqutishat merged commit a755fd8 into hyperledger-archives:main Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants