-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add FeeHook and Swell to pzEth #4974
Conversation
…orepo into ltyu/ezEth-swell-feeHook
🦋 Changeset detectedLatest commit: 9f305d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoPZETHWarpConfig.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we add swell, can you update the warp route monitor as well?
You'll need to:
- update the monorepo image in https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/infra/src/warp/helm.ts#L25 to an image that includes this new warp route
- do the deploy
# find existing monitor name, which depends on the warp ID
$ helm ls -n mainnet3
hyperlane-warp-route-pzeth-ethereum-zircuit
# now delete the old one
$ helm del hyperlane-warp-route-pzeth-ethereum-zircuit -n mainnet3
# and now deploy the new one
# it'll prompt interactively for you to pick the right warp ID
$ yarn tsx ./scripts/warp-routes/deploy-warp-monitor.ts -e mainnet3
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoPZETHWarpConfig.ts
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoPZETHWarpConfig.ts
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoPZETHWarpConfig.ts
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
92578fb
to
c390f4d
Compare
Description
Drive-by changes
Related issues
Backward compatibility
Testing