Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use detail property rather than PerformanceEntry #1315

Open
dennypradipta opened this issue Jul 22, 2024 · 4 comments
Open

Use detail property rather than PerformanceEntry #1315

dennypradipta opened this issue Jul 22, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers Tech Debt Techdebt need to be implemented the sooner the better, as its getting expensive if implemented later

Comments

@dennypradipta
Copy link
Contributor

In the newest build of Monika, there are deprecation warnings:

2024-07-22 14:02:39.028 | (node:1) [DEP0152] DeprecationWarning: Custom PerformanceEntry accessors are deprecated. Please use the detail property. 
2024-07-22 14:02:39.029 | (Use `node --trace-deprecation ...` to show where the warning was created)

This should be replaced with detail property rather than use PerformanceEntry

@haricnugraha haricnugraha added Tech Debt Techdebt need to be implemented the sooner the better, as its getting expensive if implemented later good first issue Good for newcomers labels Aug 9, 2024
@suyono3484
Copy link
Contributor

I did a quick check. It looks like the PerformanceEntry comes from one of the dependencies (or indirect dependencies).

How did I check? I ran this command in the root of the source directory: grep -inr "performanceentry" * | grep -v "js.map". The command only yields results after I run npm ci and npm run build --workspaces --if-present. Using a clean source tree yielded no results.

@dennypradipta
Copy link
Contributor Author

dennypradipta commented Aug 16, 2024

The error originally was found on the Grafana for Symon:
image

I'm guessing that this happened only in Monika Docker images, as Symon uses dockerized version. I could be wrong though, but the logs point out that there is a command that you can run to detect it:

node --trace-deprecation ...

@suyono3484
Copy link
Contributor

I pulled the latest docker image of monika from the docker hub. I couldn't reproduce the deprecation message. @dennypradipta, could you share the config where monika produces the deprecation message?

@suyono3484
Copy link
Contributor

@dennypradipta shared the configuration where Monika produced the deprecation message with me, but I still couldn't reproduce the message using docker locally. After some discussion, the message might be logged when Monika runs in Symon mode. I am reassigning this issue to @dennypradipta since he has more knowledge related to Symon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Tech Debt Techdebt need to be implemented the sooner the better, as its getting expensive if implemented later
Projects
None yet
Development

No branches or pull requests

3 participants