You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I received some advice from fellow fedora rust packagers about packaging these crates. The main suggestion is to move codegen to a build.rs in each relevant crate. There isn't a circular dependency that would block this, and this would guarantee that the generated files are always up-to-date. The main concern is about types.bin being rather obscure, and on Fedora side we should be re-generating the code, which would be difficult if these are in the workspace. Would that be ok with you?
Another uncertain question we have is with the inclusion of BSD-3-Clause license which seems to be from protobuf files, and we are not sure if the license in Cargo.toml should reflect the source code or the artifacts. At the very least though, the Apache-2.0 license need to be included
The main project is licensed under
MIT
, but it seems to containApache-2.0
licensed files as well. Shouldn't theCargo.toml
file reflect that?Additionally the generated files like
types.bin
have embeddedBSD-3-Clause
license text.The text was updated successfully, but these errors were encountered: