"make_service_fn" - gone. Where is it?

[ally9335]

Version
1.0

Platform
any

Description
there used to be the function hyper::service::make_service_fn

Now it's gone. There's no mention of it in the docs, no in the ChangeLog, nowhere. Where is it?

How to convert this into v1.0x?

    let sf = make_service_fn(|_connection| async {
        Ok::<_, Infallible>(service_fn(move |req| handle_post_req(req)))
    });

[seanmonstar]

The Server and make_service_fn are gone, you should use a loop { let conn = listener.accept().await; ... } instead. See https://hyper.rs/guides/1/upgrading/

[wiseaidev]

I think it would be best if you could share a simple implementation of this struct, perhaps make it built-in to Hyper so we can import it easily:

hyper/examples/service_struct_impl.rs

Line 15 in 8241f91

use support::TokioIo;

The reason for this is that serving new connections now requires a custom struct that implements Read, Write, Unpin traits along with the service:

hyper/examples/service_struct_impl.rs

Line 32 in 8241f91

let io = TokioIo::new(stream);

hyper/examples/service_struct_impl.rs

Line 35 in 8241f91

if let Err(err) = http1::Builder::new().serve_connection(io, svc_clone).await {

[EleisonC]

Hey @ally9335 I found this in https://hyper.rs/guides/0.14/server

[dswij]

That guide is for v0.14, while the question is for v1.0. v1.0 introduces breaking changes, one of which is removing make_service_fn.

As the answer above stated, this guide is probably answers the question better: https://hyper.rs/guides/1/upgrading/

[meawoppl]

FWIW, the upgrading link above does not really discuss this. Perhaps it changed since linked?