clean up exposed crate features #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
features-cleanup
branch
from
4a5cce9
to
9514b49
Compare
|
@howardjohn I've adjusted some of the features needed to use the legacy client, could you confirm for me that with the changes, your use case works? |
Thanks! This works for our case, but looks like #49 broke us. With #51 + this PR everything is working fine |
seanmonstar
force-pushed
the
features-cleanup
branch
from
9514b49
to
bf0cfc8
Compare
- Put `TokioExecutor` and `TokioIo` into a single `rt::tokio` module. - The `rt::tokio` module is behind a `tokio` crate feature. - Changed `auto` crate feature to `server-auto`. - Added `client-legacy` crate feature, with `client::legacy` behind it. - Removed `tcp` and `runtime` features, code now depends on the `tokio` feature.
seanmonstar
force-pushed
the
features-cleanup
branch
from
bf0cfc8
to
990f918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokioExecutorandTokioIointo a singlert::tokiomodule.rt::tokiomodule is behind atokiocrate feature.autocrate feature toserver-auto.client-legacycrate feature, withclient::legacybehind it.tcpandruntimefeatures, code now depends on thetokiofeature.