Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #1330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/lib/prb-test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ tests do what you intend them to do.

### 2. No Release Versioning

DSTest doesn't version its releases, which makes it difficult to future-proof consumer repos. It's quite easy to to
DSTest doesn't version its releases, which makes it difficult to future-proof consumer repos. It's quite easy to
accidentally update your git submodules and thus break your test suites. For
[some users](https://github.com/dapphub/ds-test/issues/32), this is a real pain.

Expand Down
4 changes: 2 additions & 2 deletions contracts/test/foundry/marketplace/executionStrategies/CollectionOffers.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ contract CollectionOrdersTest is ProtocolBase {
(bytes32 merkleRoot, bytes32[] memory proof) = _mintNFTsToOwnerAndGetMerkleRootAndProof({
owner: takerUser,
numberOfItemsInMerkleTree: 5,
// Doesn't matter what itemIdInMerkleTree is as we are are going to tamper with the proof
// Doesn't matter what itemIdInMerkleTree is as we are going to tamper with the proof
itemIdInMerkleTree: 4
});
makerBid.additionalParameters = abi.encode(merkleRoot);
Expand Down Expand Up @@ -355,7 +355,7 @@ contract CollectionOrdersTest is ProtocolBase {
(bytes32 merkleRoot, bytes32[] memory proof) = _mintNFTsToOwnerAndGetMerkleRootAndProofAccountAllowlist({
owner: takerUser,
numberOfAccountsInMerkleTree: 5,
// Doesn't matter what itemIdInMerkleTree is as we are are going to tamper with the proof
// Doesn't matter what itemIdInMerkleTree is as we are going to tamper with the proof
accountInMerkleTree: accountInMerkleTree
});
makerBid.additionalParameters = abi.encode(merkleRoot);
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/foundry/marketplace/executionStrategies/HypercertCollectionOffers.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ contract HypercertCollectionOffersTest is ProtocolBase {
(bytes32 merkleRoot, bytes32[] memory proof) = _mintNFTsToOwnerAndGetMerkleRootAndProofAccountAllowlist({
owner: takerUser,
numberOfAccountsInMerkleTree: 5,
// Doesn't matter what itemIdInMerkleTree is as we are are going to tamper with the proof
// Doesn't matter what itemIdInMerkleTree is as we are going to tamper with the proof
accountInMerkleTree: accountInMerkleTree
});
makerBid.additionalParameters = abi.encode(10_000, merkleRoot);
Expand Down