-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Expose the worker in a specific file instead of inlining it? #15
Comments
Also look at how it's handled in other libraries: |
Also see https://github.com/surma/rollup-plugin-off-main-thread (seen in https://www.npmjs.com/package/microbundle#building-module-workers), in particular look at the gist which shows the result: https://gist.github.com/surma/a02db7b53eb3e7870bf539b906ff6ff6 Also (unrelated): should we look at https://github.com/GoogleChromeLabs/comlink? It removes the need to use postMessage... Not sure if it's a good idea to add this extra-layer though. |
The worker is currently inlined (base64):
hyperparam-cli/packages/components/src/workers/parquetWorkerClient.ts
Line 1 in c536f49
The result from
npm run build
:The alternative is to remove
&inline
. In this case, the result ofnpm run build
is:But it means the users must serve the worker file in their app, which means docs + support.
The text was updated successfully, but these errors were encountered: