-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Configuration refactor #82
Open
Menci
wants to merge
93
commits into
hykilpikonna:v1-dev
Choose a base branch
from
Menci:config-refactor
base: v1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6,052
−3,042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clansty
reviewed
Nov 7, 2024
AquaMai/Mods/CustomKeyMap.cs
Outdated
} | ||
} | ||
|
||
// Why not use DB.KeyCodeID directly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为它在 Assembly-CSharp.dll 里面,而 MaiChartManager 不会附带它。但是 MaiChartManager 会加载所有 Enum 的值放在下拉选择框里给用户选择
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
明白了!
Menci
force-pushed
the
config-refactor
branch
from
November 23, 2024 06:17
c0d6513
to
b08a5ac
Compare
Menci
force-pushed
the
config-refactor
branch
from
November 23, 2024 06:44
e2eddc3
to
481b226
Compare
…o config-refactor
…o config-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.