Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note probability inconsistency #796

Closed
thijz opened this issue Jan 28, 2020 · 4 comments
Closed

note probability inconsistency #796

thijz opened this issue Jan 28, 2020 · 4 comments

Comments

@thijz
Copy link
Member

thijz commented Jan 28, 2020

Hydrogen version * : 0d3bb86
Operating system + version : ubuntu 19.10
Audio driver + version : any


note probability (great feature BTW !!!) is available but it's not :-)

you can dial in a probability value per note :
image

however, there is no 'master' dial for probability in the mixer

told you : it's there, but it's not :-D

@mauser
Copy link
Member

mauser commented Mar 5, 2020

Hi Thijz,

just to get this issue right: You mean that the per-note probability works for you, but you need a general, master probability fader which would affect all notes?

How would the master probability and the per-note probability work together? Multiply both (if set?) ?

@thijz
Copy link
Member Author

thijz commented Mar 9, 2020

Hi Sebastian,
This is something that is already implemented on a test branch by @elpescado
(see #525 (comment))

i assumed that the master section had to be there to make proper use of the probability, but i guess you could use it without
adding the master section does however greatly improve the usability of this feature

@elpescado
Copy link
Contributor

Hi,

Sorry for late reply. I've implemented this feature in two parts. Part one consisted of probability bars in pattern editor, and that part has already been merged and is scheduled for 1.0.0 release. Part 2.0 builds upon that wort and expands it further by adding two "master" controls that adjust how random notes are played. I consider that more or less complete (sans documentation), but it hasn't been merged yet. As much as I'd like to see it merged, I don't feel confident that it should be part of 1.0.0 release.

@thijz
Copy link
Member Author

thijz commented Mar 10, 2020

Thnx for the update @elpescado , your info makes sense
lets move the 'master section' part to a later release
closing ticket

@thijz thijz closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants