Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of warmup in calc test #7

Open
terminalsin opened this issue Aug 6, 2023 · 2 comments
Open

Lack of warmup in calc test #7

terminalsin opened this issue Aug 6, 2023 · 2 comments

Comments

@terminalsin
Copy link

Issue
Calc test is consistent due to a lack of warmup

Solution
Add a call for each method before it is iterated. Then, iterate the methods as done previously. Then repeat the class 10x times, and only then take their mean and median and measure those. This would be a much more accurate way at measuring performance respective to the obfuscator.

@huzpsb
Copy link
Owner

huzpsb commented Aug 6, 2023

Hmm...
[s]Can I say this check is made alike this simply because I want to count the warm-up time in? With things like MyJ2C+VMP, the warm up time can be up to 200ms per class and I found that annoying.[/s]
Maybe I would add a seperate flag for warm-up and modify this check accoardingly. Thank you for your suggestion.

@terminalsin
Copy link
Author

Hmm... [s]Can I say this check is made alike this simply because I want to count the warm-up time in? With things like MyJ2C+VMP, the warm up time can be up to 200ms per class and I found that annoying.[/s] Maybe I would add a seperate flag for warm-up and modify this check accoardingly. Thank you for your suggestion.

Yeah but once executed and cached, JIT assists and makes execution flawless. Performance should measuring consistent calls in an application, not one time loading schemes.

@huzpsb huzpsb pinned this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants