Thanks for being willing to contribute!
Working on your first Pull Request? You can learn how from this free series How to Contribute to an Open Source Project on GitHub.
- Ensure .NET Core SDK version >= 2.0.0 is installed
- Fork and clone the repo
dotnet restore
to install dependencies- Create a branch for your PR
If you are adding a language translation you will need to do the following:
- Determine the language culture name (LCN) to use. You can reference Table of Language Culture Names, Codes, and ISO Values Method for help.
- Add a
Resources.[LCN].resx
file than provides the translation. You can use one of the existing ones as a pattern. In general, please use only the first part of the culture name which denotes the language itself and not the country/region. This will allow the translation to be used more widely. However, if the language is very much specific to a country/region then using the second part of of the name is appropriate. For example, there are 5 culture names for Germany (de-AT, de-DE, dr-LI, de-LU, de-CH) but we only have a resource file namedResources.de.resx
. This allows this translation to be used for any of the specific culture names that would be passed in at runtime. However, for Chinese, we haveResources.zh-CN.resx
defined because the translation is Chinese Simplified and specific to China itself. - Create a TestsFormats.[LCN].cs file in CronExpressionDescriptor.Test project with tests for the translation. You can use one of the existing test files as a pattern.
- Add the translation to the
README.md
i18n list and the section of the CronExpressionDescriptor/CronExpressionDescriptor.csproj file
- Run tests with
dotnet test
from theCronExpressionDescriptor.Test
folder (or,dotnet test test/Test.csproj
from root folder). - Commit and push changes up to GitHub
- Create a Pull Request. Please use a simple description that explains the changes in brief.