Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player nationality missing? #1

Open
mkotov13 opened this issue Apr 27, 2017 · 4 comments
Open

Player nationality missing? #1

mkotov13 opened this issue Apr 27, 2017 · 4 comments

Comments

@mkotov13
Copy link

Hi,

Please correct me if I'm wrong, but the dataset is missing players' nationality. Is there any way that can be added?

Thanks!

@kylemh
Copy link

kylemh commented Apr 27, 2017

It's totally dependent on @hugomathien 's dataset.

It looks like he gets player data from sofifa.com which declares a player's nationality via a poorly-named image (aka something that's tough to scrape in a clean way).

@ChaiBapchya
Copy link

Since these are actualy players, one way would be to crawl Wikipedia or any trusted site with details of Football players and store their nationality information. I can do that

  1. Decide the trusted site
  2. Crawl the site - retrieve - Player Name - Nationallity
  3. Update the database with missing nationality

@mkotov13
Copy link
Author

@ChaiBapchya love the idea! One suggestion for a website to scrape instead of Wikipedia is Futhead.com, since their information is structured better, so it will be easier to scrape :)

@ChaiBapchya
Copy link

Alright. I will work on this and get back to you with the scrape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants