Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to tidy_override(): make extend = TRUE by default, allow data frame argument to glance #177

Open
hughjonesd opened this issue Jul 30, 2020 · 1 comment
Open

Improvements to tidy_override(): make extend = TRUE by default, allow data frame argument to glance #177

hughjonesd opened this issue Jul 30, 2020 · 1 comment
Labels
enhancement

Comments

@hughjonesd
Copy link
Owner

extend = FALSE by default is just a PITA and constantly leads to surprises. Also, let glance take a data frame - a common pattern is using glance on the original model, then running e.g. coeftest and tidy_overriding that.
@hughjonesd
Copy link
Owner Author

Data frame argument to glance should now work (and maybe did before, sometimes). extend = FALSE is a breaking change so will have to wait a little; I've improved the error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hughjonesd