-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Extend training support to all trainers #2101
Comments
Duplicate #1811, closing it in favour of this one |
Hi, it looks like it'd be just the extension of the as for instance I didn't check for the others but compared the scripts of |
@grumpyp yes I think this is all one needs - a better solution would be to have an automated way to populate this constant by globbing all the |
yes definitely! If you want, assign the issue to me please. I'll try to get a PR out today. |
assigned! thanks for the offer to help 🤗 |
hi @lewtun I didn't want to manipulate It now creates the commands dynamically using a utility function which is cached. Let me know if that works for you or if it needs changes. Thanks for the opportunity to contribute. |
Feature request
The CLI currently supports training models with SFT/DPO/KTO:
trl/trl/commands/cli.py
Line 24 in 6859e04
It would be good to extend this support to all trainers so that we have a consistent API and also learn which parts of our scripts need refactoring to support this usage.
This could be tackled in separate PRs to keep things lightweight, and I'll track here the trainers in terms of priority to add (based on Hub usage):
Motivation
It is somewhat annoying that one cannot train a model through the CLI as this is helpful for fast debugging / iterations.
Your contribution
Happy to open PRs, but this could be a good first issue for new contributors!
The text was updated successfully, but these errors were encountered: