Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Correctly set device of input data in bnb test #2227

Merged
merged 2 commits into from
Nov 21, 2024
Merged

FIX Correctly set device of input data in bnb test #2227

merged 2 commits into from
Nov 21, 2024

Commits on Nov 20, 2024

  1. FIX Correctly set device of input data in bnb test 

    Fixes a failing CI bitsandbytes CI test.

The input data was on CPU but the model is on GPU, resulting in an
error. Note that this mismatch was not an issue previously because
accelerate added an AlignDevicesHook that took care of this. With the
latest accelerate, this is no longer the case, whereas the hook is
present for v1.1.1.

In any case, it's better that we set the device of the data explicitly,
so I think this is a safe change. But it would be good to know what
happened that caused this change.
    @BenjaminBossan
    BenjaminBossan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    249d6ae View commit details
    Browse the repository at this point in the history

  2. Same fix for 2 more tests

    @BenjaminBossan
    BenjaminBossan committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6db322c View commit details
    Browse the repository at this point in the history