Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve INC CI test torch version #1027

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

changwangss
Copy link
Contributor

@changwangss changwangss commented Nov 25, 2024

What does this PR do?

INC and INC IPEX are currently maintaining torch 2.4 and 2.5 but the CI have torch 2.2 and 2.3, which caused errors.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@changwangss changwangss changed the title Improve INC and IPEX CI test torch version Improve INC CI test torch version Nov 25, 2024
@changwangss
Copy link
Contributor Author

changwangss commented Nov 25, 2024

All INC CI passed, Could you please take a look about the IPEX issue? @jiqing-feng
If you fix it in another PR, please let me and @AlexKoff88 know.

@jiqing-feng
Copy link
Collaborator

The error brings by #975

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Nov 25, 2024

when was the backward compatibility broken ? is there a table somewhere that we can link to for users to downgrade inc for torch>2.3 ? can you please also add torch>=2.4 in inc extra to reflect this constraint.

@jiqing-feng
Copy link
Collaborator

when was the backward compatibility broken ? is there a table somewhere that we can link to for users to downgrade inc for torch>2.3 ?

Hi Llyas, I think you can just ignore the failed tests in IPEX because we are refactoring the IPEXModel, in our new architecture, all ipex tests passed. So you can just review #1009

@IlyasMoutawwakil
Copy link
Member

The error brings by #975

the pr you're mentioning only robustified the CI to make sure we're testing specific torch/ipex versions. no ipex modeling files were changed.

@jiqing-feng
Copy link
Collaborator

The error brings by #975

the pr you're mentioning only robustified the CI to make sure we're testing specific torch/ipex versions. no ipex modeling files were changed.

I see, there are some errors when upgrading torch to 2.4 in the current IPEXModel, but we are all fixed in #1009

@IlyasMoutawwakil
Copy link
Member

okay ! let's add the version pinning in #1009

@jiqing-feng
Copy link
Collaborator

okay ! let's add the version pinning in #1009

And please merge this PR, it's just for upgrading torch version of INC CI

@IlyasMoutawwakil IlyasMoutawwakil merged commit 8fcc0ec into huggingface:main Nov 25, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants