-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint 1.3 backwards compatibility #152
base: main
Are you sure you want to change the base?
Conversation
Hello, Thank you for your PR. As I understand it, you are verifying the checkpoint version. If it is 1.3, a different pattern will be used to retrieve the shards; otherwise, the existing pattern will be used. I suspect that this approach may not resolve all the issues, given that the checkpoint version 1.3 was only added to the main branch 4 days ago (see commit), whereas the bug was introduced a month and a half ago in this commit. Additionally, checking for version 1.2 seems problematic as it might disrupt the loading logic for all checkpoints before this commit. Timeline: We have already merged a quick fix that utilized a script to modify the file name: PR #151. Could you build upon this solution? Perhaps making it automatic when this pattern is detected, instead of requiring users to run the script manually. I really appreciate your contribution. |
Thanks for the feedback. I implemented the suggested changes and tested it locally. Seems to be working ok. Let me know if you have any other comments. |
This pull request introduces three main additions:
.safetensors
suffix incorrectly placed.serialize.weights.load_weights
toserialize.utils.get_path
thanks to the addition ofreturn_all_matches
keyword.