Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Unit 1, sampling from observation space #349

Closed
Tracked by #378
dfomin opened this issue Jun 11, 2023 · 2 comments
Closed
Tracked by #378

[UPDATE] Unit 1, sampling from observation space #349

dfomin opened this issue Jun 11, 2023 · 2 comments

Comments

@dfomin
Copy link

dfomin commented Jun 11, 2023

The observation space is 8 float numbers but we know from the documentation that the last 2 numbers are actually boolean so they can be only 0 or 1. In a line
print("Sample observation", env.observation_space.sample()) # Get a random observation
we have 8 random floats including the last 2 of them and I found it a bit misleading since we can never get this observation from the environment. Maybe some additional clarification is needed here.

@simoninithomas
Copy link
Member

Hey there 👋 thanks for pointing this out. I'm adding it to the next update list (August Update)

@simoninithomas simoninithomas mentioned this issue Aug 5, 2023
15 tasks
@simoninithomas
Copy link
Member

simoninithomas commented Aug 5, 2023

Hey there 👋 thanks I updated the notebook and the hands-on.mdx 🤗 #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants