-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working for JupyterLab 4.0? #4
Comments
You may have already found this, but this discussion thread appears to identify why it stopped working—breaking API changes in the new version of CodeMirror that shipped with JL 4. :( |
Right, it should be possible to make it work, but it didn't look like a quick fix when I initially looked into it. So I've just been using JupyterLab 3.x myself, for the time being. Here are my notes from back then, which I should have posted here:
|
I got a hack working. It should be possible to implement the changes into an extension, but this hack provides me with something that is working in the meantime:
|
Thank you for your work on this! I probably won't be able to dig into it myself, to try it out, for several months, but I really appreciate it. |
The workaround suggested by @ticoneva doesn't seem to work for me. I may be misreading the instructions, but I made the following changes on my server:
I'm pinging @ozak as well since they opened a similar issue. |
I also tried it but it didn't work. |
I posted the wrong locations in my original instructions. Thanks @arnonerba for pointing that out. I have modified the instructions accordingly. I would also like to point out that the modification might require---or at least would be a lot easier to apply to---non-minified CodeMirror files, which does not seem to come with some versions of Jupyter Lab. Finally, after the modifications you might need to rebuild Jupyter Lab for this to work:
|
@ticoneva thanks for responding and for updating your original instructions. I've tried |
What OS are you using? It has been a while since I implemented the hack and honestly, I messed around with a lot things, so I cannot confirm with 100% certainty that these steps are all that it takes. I will start fresh on a VM and see if I can provide better instructions. |
I'm running TLJH on Ubuntu Server 22.04 LTS with Stata 18. Thank you for your help! |
I'm on MacOS 14.3. |
I have verified that the following steps should work:
|
Just a wrapper package for solution offered by @ticoneva
Apparently, Stata syntax can be well handled using legacy mode. Migrating to codemirror6 using |
@lutherbu Thanks for putting together the package! That would make things so much easier for everyone. |
It's not working for me with a new install of JupyterLab 4.0.5.
The text was updated successfully, but these errors were encountered: