Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the repository cache #7

Open
drusellers opened this issue May 3, 2016 · 6 comments
Open

Return the repository cache #7

drusellers opened this issue May 3, 2016 · 6 comments

Comments

@drusellers
Copy link
Member

GET ~/cache/<owner>/<repo>/issues

What kinds of headers should it return?

Should it return the same api payload as GET /orgs/:org/issues

https://developer.github.com/v3/issues/#list-issues

@dahlbyk
Copy link
Member

dahlbyk commented May 3, 2016

What kinds of headers should it return?

As close to https://api.github.com/repos/<owner>/<repo>/issues as possible, using sensible min/max where applicable, e.g.

  • if we spent any of our GitHub rate limit, return the lowest X-RateLimit-Remaining value
  • probably Date and corresponding Etag from the first (newest) page of results

Should it return the same api payload as GET /orgs/:org/issues

Same payload as https://api.github.com/repos/<owner>/<repo>/issues (which should align - array of issue payloads).

@rauhryan
Copy link
Member

rauhryan commented May 3, 2016

It would be really awesome if the cache returned all of the issues in one call.

At least I dream that could be a possibility, as well as things like joining in attached branches and things

@rauhryan
Copy link
Member

rauhryan commented May 3, 2016

And having queryable unstructured metadata that we could attach, so we could get rid of our weird embedded data hack

@drusellers
Copy link
Member Author

@drusellers
Copy link
Member Author

And having queryable unstructured metadata that we could attach, so we could get rid of our weird embedded data hack

We can do it on both the payload and the headers. JSONB + HSTORE FTW

@drusellers
Copy link
Member Author

It would be really awesome if the cache returned all of the issues in one call.

Totally doable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants