-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache an individual issue #6
Comments
Never? Unsure if there's a point to flat out eviction, unless it is requested that we purge our cache.
Pretty close. If we're serving from cache we won't have up-to-date data for some headers (rate limit), so those would be excluded.
Date will be most important. If we have an ETag, we can return it, but we would only get that from a detail request (most often we get issue payloads from multi-issue queries. |
Interesting questions
Issues are pretty volatile. So they should be dynamic and check the API with the last ETag I think we could get a lot more juice with caching things that change less, like collaborators, labels, repo details
I don't think so, eerrr I don't really know the answer to that question. Maybe we could just relay the same headers, let's talk more about it
ETag is the one that is used to ask GitHub if things have changed And Links is the one that we need to parse out for pagination and such |
Questions
The text was updated successfully, but these errors were encountered: