Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fixed in evaluate service but not fixed in evaluator #264

Open
jinfazhu opened this issue Sep 13, 2022 · 0 comments · Fixed by #265
Open

typo fixed in evaluate service but not fixed in evaluator #264

jinfazhu opened this issue Sep 13, 2022 · 0 comments · Fixed by #265

Comments

@jinfazhu
Copy link
Contributor

if evaluate_result.get("status") != "sucess":

if evaluate_result.get("status") == "sucess":

if results.get("status") != "sucess" and error_count <= error_threshold:

if self.calculate_metric and results.get("status") != "sucess" and error_count <= error_threshold:

not consistent with
self.result = {"latency": "9999", "out_data": [], "status": "success", "timestamp": "", "error_message": ""}

@zhangjiajin zhangjiajin linked a pull request Oct 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant