-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node-datachannel to 0.5.x #5
Comments
I am looking into this, but it's a little tricky, due to a) newly flaky tests in this repo (I think due to Chrome changes?) and b) node-datachannel 0.5.0+ moving to pure ESM, so it can't easily be used in CommonJS modules like this one. Nothing insurmountable, but it might take a little while. Any PRs or testing to help work through those issues is very welcome 😄 |
when setting up http toolkit server, hotpatching const NodeDataChannel = import("node-datachannel"); worked for me just fine :p however, i'm not sure if that wouldn't require modernising the tsconfig to the new import method to work properly |
😆 very neat. Probably not the solution I want to ship into production though I'm afraid! I'll let you know once I've got something working here. |
Oh, to be clear: it's probably going to require converting this module to ESM too, as a new breaking release, so you might want to be prepared for that downstream. |
I've just released v0.3.2, which uses the latest node-datachannel (without migrating to ESM, by using https://github.com/nktnet1/import-sync internally). @ptrcnull Can you test it out and let me know if that works for you now? |
0.5.0 fixes an issue when building from source on modern Linux systems: murat-dogan/node-datachannel#183
The text was updated successfully, but these errors were encountered: