Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not working properly on demo site #41

Open
jaredweiss opened this issue Jul 23, 2015 · 12 comments
Open

Icons not working properly on demo site #41

jaredweiss opened this issue Jul 23, 2015 · 12 comments

Comments

@jaredweiss
Copy link
Contributor

see http://river-view.herokuapp.com/index.html

The small icons on the buttons (i.e. Details, JSON API, and Source Code) are showing up as boxes rather than the proper icons.

@rhyolight
Copy link
Collaborator

What browser?


Matt Taylor
OS Community Flag-Bearer
Numenta

On Thu, Jul 23, 2015 at 3:39 PM, Jared Weiss [email protected]
wrote:

see http://river-view.herokuapp.com/index.html

The small icons on the buttons (i.e. Details, JSON API, and Source Code)
are showing up as boxes rather than the proper icons.


Reply to this email directly or view it on GitHub
#41.

@jaredweiss
Copy link
Contributor Author

Chrome version 44.0.2403.107

@jaredweiss
Copy link
Contributor Author

screen shot 2015-07-28 at 1 24 24 pm

@rhyolight
Copy link
Collaborator

I'm on Version 44.0.2403.107 (64-bit) and it looks great. Hey @brev I hate to drag you into this, but bootstrap glyphs aren't working on Jared's Chrome, but they are on mine. Do you know why this might happen?

@brev
Copy link

brev commented Jul 28, 2015

@rhyolight broken for me too, I'm seeing the below font+domain error in console:

Font from origin 'http://data.numenta.org' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://river-view.herokuapp.com' is therefore not allowed access.

Can't figure out why yours would be working OK, though.

@jaredweiss
Copy link
Contributor Author

interestingly enough, the symbols show up nicely on http://data.numenta.org/index.html

@jefffohl
Copy link
Member

in the partial, header.tpl, why not use a relative path for scripts, CSS, and such? You can see that they are absolute paths to data.numenta.org.

@rhyolight
Copy link
Collaborator

Oh, I thought this was a browser issue, but it's just a path issue.

in the partial, header.tpl, why not use a relative path for scripts, CSS, and such? You can see that they are absolute paths to data.numenta.org.

Because relative paths must be in relation to the page being rendered (not the partial template), and the partial doesn't know what its path is going to be until runtime.

@jefffohl
Copy link
Member

so you have {{baseurl}} there in case it is not installed at the root of the web server?

@rhyolight
Copy link
Collaborator

Yes. It could be installed as an express middleware, in which case "/" will
not point to the application root.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Tue, Jul 28, 2015 at 3:42 PM, Jeff Fohl [email protected] wrote:

so you have {{baseurl}} there in case it is not installed at the root of
the web server?


Reply to this email directly or view it on GitHub
#41 (comment)
.

@jefffohl
Copy link
Member

I can implement this middleware. Assign this to me if you would like me to handle it.

@rhyolight
Copy link
Collaborator

No, there is no middleware necessary to fix this issue. I was just justifying why templates are given a {{baseurl}}.

@rhyolight rhyolight added the bug label Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants