Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-2688 python-htcondor2 #619

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JaimeFrey
Copy link
Member

condor_ce_trace required major changes due to altered or removed interfaces.

condor_ce_trace required major changes due to altered or removed
interfaces.
src/condor_ce_trace Outdated Show resolved Hide resolved
Copy link
Contributor

@ColeBollig ColeBollig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... there are test failures, but I believe @timtheisen is working on them. I guess don't merge until those are resolved (unless tim says otherwise)

@kreczko
Copy link

kreczko commented Nov 14, 2024

For condor_ce_jobmetriccs does the line

htcondor = __import__("htcondor")

also need an update to

htcondor = __import__("htcondor2")

side note, with these changes, condor_ce_job metrics throws an exception:

multiprocessing.pool.MaybeEncodingError: Error sending result: 
<snip>
Reason: 'TypeError("cannot pickle 'classad2_impl._handle' object")'

@JaimeFrey
Copy link
Member Author

Looks like condor_ce_jobmetrics and web_utils.py both need that change. I'll look into the exception.

v2 ClassAds can't be pickled, so unparse them to move betwen processes.
Also fix a few imports of v1 bindings missed in previous round and stop
using xquery().
@ColeBollig
Copy link
Contributor

I did some grepping and I believe that src/audit_payloads.py and src/condor_ce_run still need to be updated

@JaimeFrey
Copy link
Member Author

@ColeBollig What branch are you looking at. I don't even see an audit_payloads.py file.

@timtheisen
Copy link
Member

I believe that he was grepping around in master (which is ancient). Perhaps, main would be a better branch. @ColeBollig @JaimeFrey

@ColeBollig
Copy link
Contributor

@JaimeFrey, Tim is right... I was looking at master branch instead of main. My bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants