-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTCONDOR-2688 python-htcondor2 #619
base: main
Are you sure you want to change the base?
Conversation
condor_ce_trace required major changes due to altered or removed interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... there are test failures, but I believe @timtheisen is working on them. I guess don't merge until those are resolved (unless tim says otherwise)
For htcondor = __import__("htcondor") also need an update to htcondor = __import__("htcondor2") side note, with these changes, condor_ce_job metrics throws an exception:
|
Looks like condor_ce_jobmetrics and web_utils.py both need that change. I'll look into the exception. |
v2 ClassAds can't be pickled, so unparse them to move betwen processes. Also fix a few imports of v1 bindings missed in previous round and stop using xquery().
I did some grepping and I believe that |
@ColeBollig What branch are you looking at. I don't even see an audit_payloads.py file. |
I believe that he was grepping around in master (which is ancient). Perhaps, main would be a better branch. @ColeBollig @JaimeFrey |
@JaimeFrey, Tim is right... I was looking at |
condor_ce_trace required major changes due to altered or removed interfaces.