Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt GB18030-2022 #107

Closed
lucacasonato opened this issue Sep 18, 2024 · 4 comments
Closed

Adopt GB18030-2022 #107

lucacasonato opened this issue Sep 18, 2024 · 4 comments

Comments

@lucacasonato
Copy link
Contributor

See whatwg/encoding#336

The changes required seem to mostly be in data files. It seems not too complex.

@hsivonen
Copy link
Owner

hsivonen commented Sep 19, 2024

The changes required seem to mostly be in data files. It seems not too complex.

There are additional sources of complexity:

  1. The generator is still on Python 2, so it needs to be run in a VM running an old OS.
  2. The upstream license has changed, so I need to review which additional places need to point to the WHATWG license.
  3. The test case generator now doesn't generate the expected test cases, since it works directly with the gb18030-ranges data, which now has entries that apply to decode but are overridden for encode.

I'll make an initial PR today, but it might not have enough time to get this to a releasable state immediately. (At least this isn't too urgent in practice.)

@hsivonen
Copy link
Owner

See #108 for progress.

@hsivonen
Copy link
Owner

Released as 0.8.35.

@lucacasonato
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants