Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquid syntax not escaped #94

Closed
amanmdesai opened this issue Jan 10, 2023 · 4 comments · Fixed by #95
Closed

Liquid syntax not escaped #94

amanmdesai opened this issue Jan 10, 2023 · 4 comments · Fixed by #95
Labels
episode 9

Comments

@amanmdesai
Copy link
Contributor

Hi @klieret @michmx,

Following is the full command which is given in the original epsiode 9 file and this is how we expect to see it on the episode website episode 9:

echo ${{ secrets.GITHUB_TOKEN }} | singularity remote login -u ${{ secrets.GHCR_USERNAME }} --password-stdin oras://ghcr.io
singularity push container.sif oras://ghcr.io/${GITHUB_REPOSITORY}:${tag}

however this is NOT the case and instead the following is rendered:

 echo $ | singularity remote login -u $ --password-stdin oras://ghcr.io
 singularity push container.sif oras://ghcr.io/${GITHUB_REPOSITORY}:${tag}

meaning that ${{ secrets.GITHUB_TOKEN }} is missing.

Any idea how to solve this?

Thanks.
@amanmdesai amanmdesai changed the title Issue with bonus episode Issue with bonus episode website version Jan 10, 2023
@klieret
Copy link
Member

klieret commented Jan 10, 2023

ah, that's probably replaced by liquid, the template engine from Jekyll

@klieret
Copy link
Member

klieret commented Jan 10, 2023

I'll take a look and fix that. Probably just needs some {{% raw %}} tags or something around it

@klieret
Copy link
Member

klieret commented Jan 10, 2023

Very nice catch! ❤️ ❤️

@klieret klieret mentioned this issue Jan 10, 2023
Merged
klieret added a commit that referenced this issue Jan 10, 2023
@klieret
Fix accidental interpretation by liquid
e0db1ae 
Closes #94
@klieret klieret changed the title Issue with bonus episode website version Liquid syntax not escaped Jan 10, 2023
@amanmdesai
Copy link
Contributor Author

Thanks a lot @klieret for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
episode 9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accidental interpretation by liquid hsf-training/hsf-training-singularity-webpage
2 participants
@klieret @amanmdesai