-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross platform media control keys support #1327
base: main
Are you sure you want to change the base?
Conversation
If |
So I looked at
In souvlaki these mostly have hardcoded values or are nonexistent: https://github.com/Sinono3/souvlaki/blob/master/src/platform/mpris/zbus.rs I only need to undo my last commit if we want to keep |
Indeed, it seems like the Souvlaki MPRIS implementation is incomplete, so it won't work as a replacement for the current I have two suggestions: Either implement MPRIS support in souvlaki properly, or use |
This reverts commit 1098afd.
@Bettehem I can't really work on souvlaki as I have no access to mac so I went with your second idea. |
So excited to finally see this merged! |
I've been using windows version for a week without issues. Anything else you need to accept the PR? |
Sorry, currently moving to a different place, so super busy at the moment.. hope to have a look at this soon. |
I would really like to merge this, but I think we should fix the souvlaki implementation first as @Bettehem said, so we can avoid having duplicate MPRIS logic in the codebase. |
@hrkfdn, please don't let perfect be the enemy of good. This would be a great improvement and cleaning up dependencies could be a follow-up for when the souvlaki implementation is improved. Just my two cents. |
I'm with @veloek here - this would be a great QoL improvement! :D |
Describe your changes
Added new
media_control
feature making use of souvlaki lib.Works on debian and windows 10. I will not be able to check on mac.
I kept the old
mpris
feature but it is not compatible withmedia_control
. Should it be removed?Code has been mostly adapted from current
mpris
implementation and https://github.com/aome510/spotify-player/.Issue ticket number and link
#703
Checklist before requesting a review
not performance improvements, etc.)