Skip to content

Commit

Permalink
Merge pull request #38 from hrimhari/release/1.4.5
Browse files Browse the repository at this point in the history
chore: remove functions from db upgrade deprecated on Moodle 3.9
  • Loading branch information
hrimhari authored Jun 10, 2020
2 parents 9ef9f7b + ca756b1 commit 1090d51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 0 additions & 6 deletions db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,5 @@
function xmldb_auth_emailadmin_upgrade($oldversion) {
global $CFG, $DB;

if ($oldversion < 2019070800) {
upgrade_fix_config_auth_plugin_names('emailadmin');
upgrade_fix_config_auth_plugin_defaults('emailadmin');
upgrade_plugin_savepoint(true, 2019070800, 'auth', 'emailadmin');
}

return true;
}
6 changes: 3 additions & 3 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

defined('MOODLE_INTERNAL') || die;

$plugin->version = 2019072300; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2015051101; // Requires this Moodle version.
$plugin->version = 2030061000; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2017111300; // Requires this Moodle version.
$plugin->component = 'auth_emailadmin'; // Full name of the plugin (used for diagnostics).
$plugin->maturity = MATURITY_STABLE;
$plugin->release = '1.4.4';
$plugin->release = '1.4.5';

5 comments on commit 1090d51

@GuillaumeAllegre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello hrimhari,
Thanks for your reactivity !
your last $plugin->version (2030061000) seems a to have a typo (2030 instead of 2020)

(I'm working with Nicolas Catusse, so I follow this bug too).

@hrimhari
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dammit... that's probably going to stay forever

@GuillaumeAllegre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... as you wish... but for now, I think we are few to have installed this, and you can fix it if you want!

@hrimhari
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the plug on the version in Moodle for now, but it will be messy to fix that for those that got it

@GuillaumeAllegre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, right.
Thanks again for your work.

Please sign in to comment.