Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subfloor elements #356

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Subfloor elements #356

wants to merge 2 commits into from

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 8, 2022 •
edited
Loading

Closes #353. Adds a Floor/Subfloor element to describe material & thickness.

Material choices are:

  • none
  • plywood
  • osb
  • wood
  • concrete
  • gypcrete
  • other

image

@shorowit shorowit added this to the v4.0 milestone Nov 8, 2022
@shorowit shorowit self-assigned this Nov 8, 2022
@shorowit shorowit changed the title Subfloor Type Subfloor elements Nov 8, 2022
@shorowit
Copy link
Contributor Author

shorowit commented Nov 8, 2022

Add "cement board"?
Should we allow multiple subfloors? (Would we also change FloorCovering to allow multiple?)

@nmerket
Copy link
Contributor

nmerket commented Nov 9, 2022

🎥 Discussion in HPXML Working Group Meeting 2022-11-08

@shorowit shorowit mentioned this pull request Nov 10, 2022
Closed
3 tasks
@shorowit shorowit marked this pull request as draft April 11, 2023 16:24
@shorowit shorowit removed this from the v4.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
enhancement schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional floor mass
2 participants
@shorowit @nmerket