Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant datatypes #339

Open
shorowit opened this issue Aug 18, 2022 · 2 comments
Open

Remove redundant datatypes #339

shorowit opened this issue Aug 18, 2022 · 2 comments
Assignees
Labels

Comments

@shorowit
Copy link
Contributor

shorowit commented Aug 18, 2022

There are probably quite a few datatypes in HPXMLDataTypes.xsd that are essentially equivalent. It would be nice to clean it up so that the file can be significantly simplified and reduced in size.

For example:

	<xs:simpleType name="CAZDepressurizationLimit_simple">
		<xs:restriction base="xs:double"/>
	</xs:simpleType>
	<xs:complexType name="CAZDepressurizationLimit">
		<xs:simpleContent>
			<xs:extension base="CAZDepressurizationLimit_simple">
				<xs:attribute name="dataSource" type="DataSource"/>
			</xs:extension>
		</xs:simpleContent>
	</xs:complexType>

Any references to this datatype could simply use the generic HPXMLDouble instead.

Would any software developers consider this a breaking change?

@shorowit shorowit added this to the v4.0 milestone Sep 13, 2022
@shorowit
Copy link
Contributor Author

@nmerket is in favor moving towards more generic datatypes. We'd like more people to weigh in if they have any concerns.

@nmerket
Copy link
Contributor

nmerket commented Sep 20, 2022

This was referenced Jul 21, 2023
@shorowit shorowit self-assigned this Jul 21, 2023
@shorowit shorowit removed this from the v4.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants