respect the webinterface config setting #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpolthof
requested changes
Jan 21, 2017
|
|
||
| // Extract the real key from the translation. | ||
| if (preg_match("/^{$group}\.(.*?)$/sm", $key, $match)) { | ||
| if (preg_match("/^{$group}\\.(.*?)$/sm", $key, $match)) { |
There was a problem hiding this comment.
You've seem to have added an extra slash. This slash however will break functionality. The single slash is intended to restrain the following dot from being counted as a wildcard character. Adding an extra slash would result in the dot being a wildcard.
hpolthof
approved these changes
Jan 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an environment where access to /_translations is gated by the webserver itself, it's okay to show the webinterface in production. This change respects the user's config setting, and defaults the webinterface boolean to the APP_DEBUG var, if set, and false otherwise. The user of course is free to override that in their own config file.