Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge outer_shape and walls on Room to one concept #203

Open
2 tasks
rsommerfeld opened this issue Jan 24, 2022 · 0 comments
Open
2 tasks

Merge outer_shape and walls on Room to one concept #203

rsommerfeld opened this issue Jan 24, 2022 · 0 comments
Labels
Data Administration Indoor Map P2 Priority: Low

Comments

@rsommerfeld
Copy link
Contributor

Currently walls is unused and only outer_shape is used. To reduce this premature optimization, remove walls.

Acceptance Criteria:

  • There is only one attribute instead of walls and outer_shape
  • The name of that remaining attribute communicates its intent
@rsommerfeld rsommerfeld added P2 Priority: Low and removed P5 Priority: Highest labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Data Administration Indoor Map P2 Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsommerfeld