Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on room on indoor map opens room detail page #216

Open
anonym-HPI opened this issue Feb 2, 2022 · 4 comments
Open

Click on room on indoor map opens room detail page #216

anonym-HPI opened this issue Feb 2, 2022 · 4 comments
Assignees

Comments

@anonym-HPI
Copy link

As a user I want to see the detail page of a room when clicking on it on the map, because I don't want to have to search for a room when I know which room I want to see the detail page of.

@oleschl oleschl self-assigned this Feb 4, 2022
@oleschl
Copy link
Contributor

oleschl commented Feb 4, 2022

It already is kinda working. Two issues:

  • how should we map between the leaflet polygon and the database entry of a room (thats why i am only searching and not showing the detail page)
  • multiple click events eg. place marker vs click on room
clickOnRoom.mp4

@oleschl
Copy link
Contributor

oleschl commented Feb 5, 2022

@anonym-HPI could you also have a look at the issue here? Right now the first click on the map places a marker and the second places another one and you can start a route. However, the user probably only wanted to see the detail page and not get a route. You can see the issue in the video above: the first click displays the search result but second opens the route window instead of the detail page of room C-E.15 (left bottom corner).

@anonym-HPI
Copy link
Author

@oleschl correct, it was intended to see the detail page of the room. I am thinking how this interfears with the routing, as when you want to navigate to a room it should probably also be clickable.
Can you remove the first pin with clicking again on it? So that only the second is marked and shown in the left bottom corner? (like in the beginning of the clip).

@anonym-HPI
Copy link
Author

It will exist (in development) a script which will fill polygons into the database, as a site note.

It would probably be good to have in every Geojson a room id (unique over the complete project, could be just the id of the room in the database), that links to the room in the database and could then be used to open it.

What do you think @oleschl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants