From f4bfc27a6de602de05ccf1198e66433938a1535f Mon Sep 17 00:00:00 2001
From: Lukas Barragan Torres <lukas.barragantorres@ugent.be>
Date: Mon, 16 Sep 2024 14:56:57 +0200
Subject: [PATCH] dont make PR when nothing changed

---
 scripts/modules_auto_pr/modules_auto_pr.sh | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/scripts/modules_auto_pr/modules_auto_pr.sh b/scripts/modules_auto_pr/modules_auto_pr.sh
index 169c7d1bedb..94ef7d6b80f 100755
--- a/scripts/modules_auto_pr/modules_auto_pr.sh
+++ b/scripts/modules_auto_pr/modules_auto_pr.sh
@@ -20,11 +20,12 @@ PR_TITLE="Auto Update Modules [$HUMAN_TIMESTAMP]"
 make_pr_body() {
   local n_added_modules="$1"
   local n_removed_modules="$2"
+  local n_modified_modules="$3"
 
   echo "This is an automated pull request updating the markdown files of all available modules."
   echo ""
   echo "Changes:"
-  echo "- Updated the markdown files of all previously available modules"
+  echo "- Updated $n_modified_modules modules"
   echo "- Added $n_added_modules new modules"
   echo "- Removed $n_removed_modules modules"
 }
@@ -76,6 +77,7 @@ main() {
   # Calculate the number of added and removed modules
   N_ADDED_MODULES=$(git show --name-status HEAD | grep -e "^A.*\.md$" | wc -l)
   N_REMOVED_MODULES=$(git show --name-status HEAD | grep -e "^D.*\.md$" | wc -l)
+  N_MODIFIED_MODULES=$(git show --name-status HEAD | grep -e "^M.*\.md$" | wc -l)
 
   # Push the new branch to GitHub
   git remote add fork "$fork_url"
@@ -85,11 +87,17 @@ main() {
   gh repo set-default $REPO_URL
 
   # Create a pull request using GitHub CLI. Pull request is automatically created into the default repository.
-  gh pr create \
-    --title "$PR_TITLE" \
-    --body  "$(make_pr_body "$N_ADDED_MODULES" "$N_REMOVED_MODULES")" \
-    --base  "$BASE_BRANCH" \
-    --head  "$fork_user:$BRANCH_NAME" \
+  # Make PR if add + del + mod > 0
+  if [ $((N_ADDED_MODULES + N_REMOVED_MODULES + N_MODIFIED_MODULES)) -gt 0 ]; then
+    gh pr create \
+      --title "$PR_TITLE" \
+      --body  "$(make_pr_body "$N_ADDED_MODULES" "$N_REMOVED_MODULES" "$N_MODIFIED_MODULES")" \
+      --base  "$BASE_BRANCH" \
+      --head  "$fork_user:$BRANCH_NAME"
+  else
+    echo_info "No changes detected. Skipping PR creation."
+  fi
+
 
   # Clean up
   rm -rf "$REPO_PATH"