From 8fd9fb8e8279782e7780830d3b8a0e325ec497f3 Mon Sep 17 00:00:00 2001 From: James McMullan Date: Thu, 14 Mar 2024 09:51:45 -0400 Subject: [PATCH] HPCC4J-588 HpccRemoteFileReader doesn't pass constuctor params (#694) - Fixed issue where some constructor params were not being passed from overloaded constructors Signed-off-by: James McMullan James.McMullan@lexisnexis.com Signed-off-by: James McMullan James.McMullan@lexisnexis.com --- .../dfs/client/HpccRemoteFileReader.java | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java b/dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java index 716e6c5e8..7913e9748 100644 --- a/dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java +++ b/dfsclient/src/main/java/org/hpccsystems/dfs/client/HpccRemoteFileReader.java @@ -21,7 +21,7 @@ import java.util.Iterator; /** - * Remote file reader the reads the data represented by a @see org.hpccsystems.dfs.client.DataPartition + * Remote file reader the reads the data represented by a @see org.hpccsystems.dfs.client.DataPartition * and constructs records via the provided @see org.hpccsystems.dfs.client#IRecordBuilder. */ public class HpccRemoteFileReader implements Iterator @@ -72,7 +72,7 @@ public HpccRemoteFileReader(DataPartition dp, FieldDef originalRD, IRecordBuilde * the record defintion for the dataset * @param recBuilder * the IRecordBuilder used to construct records - * @param connectTimeout + * @param connectTimeout * the connection timeout in seconds, -1 for default * @throws Exception * the exception @@ -105,47 +105,47 @@ public HpccRemoteFileReader(DataPartition dp, FieldDef originalRD, IRecordBuilde /** * A remote file reader that reads the part identified by the HpccPart object using the record definition provided. - * + * * @param dp * the part of the file, name and location * @param originalRD * the record defintion for the dataset * @param recBuilder * the IRecordBuilder used to construct records - * @param connectTimeout + * @param connectTimeout * the connection timeout in seconds, -1 for default - * @param limit + * @param limit * the maximum number of records to read from the provided data partition, -1 specifies no limit - * @param createPrefetchThread + * @param createPrefetchThread * the input stream should create and manage prefetching on its own thread. If false prefetch needs to be called on another thread periodically. - * @param readSizeKB + * @param readSizeKB * read request size in KB, -1 specifies use default value * @throws Exception * general exception */ public HpccRemoteFileReader(DataPartition dp, FieldDef originalRD, IRecordBuilder recBuilder, int connectTimeout, int limit, boolean createPrefetchThread, int readSizeKB) throws Exception { - this(dp, originalRD, recBuilder, connectTimeout, limit, true, DEFAULT_READ_SIZE_OPTION, null); + this(dp, originalRD, recBuilder, connectTimeout, limit, createPrefetchThread, readSizeKB, null); } /** * A remote file reader that reads the part identified by the HpccPart object using the record definition provided. - * + * * @param dp * the part of the file, name and location * @param originalRD * the record defintion for the dataset * @param recBuilder * the IRecordBuilder used to construct records - * @param connectTimeout + * @param connectTimeout * the connection timeout in seconds, -1 for default - * @param limit + * @param limit * the maximum number of records to read from the provided data partition, -1 specifies no limit - * @param createPrefetchThread + * @param createPrefetchThread * the input stream should create and manage prefetching on its own thread. If false prefetch needs to be called on another thread periodically. - * @param readSizeKB + * @param readSizeKB * read request size in KB, -1 specifies use default value - * @param resumeInfo + * @param resumeInfo * FileReadeResumeInfo data required to restart a read from a particular point in a file * @throws Exception * general exception @@ -204,7 +204,7 @@ public HpccRemoteFileReader(DataPartition dp, FieldDef originalRD, IRecordBuilde /** * Returns the stream position within the file. - * + * * @return stream position */ public long getStreamPosition() @@ -214,7 +214,7 @@ public long getStreamPosition() /** * Returns read resume info for the current position within the file. - * + * * @return FileReadResumeInfo */ public FileReadResumeInfo getFileReadResumeInfo() @@ -224,7 +224,7 @@ public FileReadResumeInfo getFileReadResumeInfo() /** * Returns read resume info for the specified position within the file. - * + * * @param streamPosition the stream position to resume from * @return FileReadResumeInfo */ @@ -242,7 +242,7 @@ public FileReadResumeInfo getFileReadResumeInfo(Long streamPosition) /** * Returns the number of messages created during the reading process - * + * * @return number of messages created */ public int getRemoteReadMessageCount() @@ -256,7 +256,7 @@ public int getRemoteReadMessageCount() /** * Returns messages created during the file reading process - * + * * @return Messages concatenated into a String */ public String getRemoteReadMessages() @@ -284,7 +284,7 @@ public void prefetch() /** * Is there more data - * + * * @return true if there is a next record */ @Override @@ -352,7 +352,7 @@ public int getAvailable() throws IOException /** * Returns the RowServiceInputStream used to read the file from dafilesrv - * + * * @return the input stream */ public RowServiceInputStream getInputStream() @@ -362,7 +362,7 @@ public RowServiceInputStream getInputStream() /** * Returns the BinaryRecordReader used to construct records - * + * * @return the record reader */ public BinaryRecordReader getRecordReader()